Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Node version range in CI, use modern Node version #66

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Update Node version range in CI, use modern Node version #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
01d0e1b
Update CI dependencies, modernize node matrix
rdmurphy Oct 8, 2024
40b1608
Allow CI to run on all pushes
rdmurphy Oct 8, 2024
2efd5fd
Just do it on every push for now
rdmurphy Oct 8, 2024
e4a9ccc
Bump Node .tool-versions to v22.9.0
rdmurphy Oct 8, 2024
9f86b0f
Allow package-lock.json to update
rdmurphy Oct 8, 2024
fa42c59
Bump engines to 18 in package.json
rdmurphy Oct 8, 2024
d08aa06
Use npm ci instead
rdmurphy Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,26 +2,22 @@ name: CI

on:
push:
branches:
- master
pull_request:
branches:
- master

jobs:
build:
runs-on: ubuntu-latest

strategy:
matrix:
node-version: [12.x, 14.x]
node-version: [18, 20, 22]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might help to drop a link to https://github.com/actions/runner-images#support-policy as comment before.


steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
uses: actions/setup-node@v4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: While this would work (and is pretty common) I personally prefer to have the whole SemVer in my workflows as this eases an (security) audit.

with:
node-version: ${{ matrix.node-version }}
- run: npm install
cache: npm
- run: npm ci
- run: npm run lint
- run: npm test
2 changes: 1 addition & 1 deletion .tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
nodejs 15.4.0
nodejs 22.9.0
8 changes: 1 addition & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
}
},
"engines": {
"node": ">=12"
"node": ">=18"
},
"dependencies": {
"lib-font": "^2.4.2"
Expand Down