Update Node version range in CI, use modern Node version #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryuno-Ki
approved these changes
Oct 8, 2024
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v1 | ||
| uses: actions/setup-node@v4 |
There was a problem hiding this comment.
Nitpick: While this would work (and is pretty common) I personally prefer to have the whole SemVer in my workflows as this eases an (security) audit.
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [12.x, 14.x] | ||
| node-version: [18, 20, 22] |
There was a problem hiding this comment.
It might help to drop a link to https://github.com/actions/runner-images#support-policy as comment before.
|
@rdmurphy If you agree with those suggestions, then I'll wait for the changes and then we can merge this puppy! 🐶 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42.
Hello! I saw the post on Mastodon and the organizing issue and decided to try and help if I can! I did a few things here, mostly with the goal of establishing a solid foundation for testing future changes against modern versions of Node.
masterand PRs againstmaster. I think this will put the matrix testing to better use (and because PRs are made of commits, those will still get tested!)v18,v20andv22.v20is the current LTS version, but it goes into maintenance mode in 15 days andv22will take its place.actions/setup-node@v4will use caching to speed up installs.v22in the project. Could see an argument for usingv20instead, but did so for the same reason as above!package-lock.jsonappeared to be out of sync because every install would update it locally. I updated the CI command to usenpm ciinstead ofnpm installwhich would catch this mismatch. Definitely some dependencies that could stand to be updated, but all tests are passing, which is nice.If any/all of this doesn't feel like it makes sense, just let me know! (Or feel free to close it if I'm way off base.)