Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Provide the partitionKey as part of the Event #32

Open
aquamatthias opened this issue Sep 26, 2017 · 2 comments
Open

Provide the partitionKey as part of the Event #32

aquamatthias opened this issue Sep 26, 2017 · 2 comments

Comments

@aquamatthias
Copy link
Contributor

Hey,

we are currently playing with reactive-kinesis. As first impression: It looks really good - so thanks for this cool library.
What I miss is the information about the partitionKey in each event which is available in Record.
If a shard is taken over by a different worker, we would like to drop buffered events from this shard.
Do you think it would make sense to add the key to the ConsumerEvent class?
Happy to create a PR, if you agree.

@markglh
Copy link
Contributor

markglh commented Oct 24, 2017

Thanks @aquamatthias - apologies for the delay I got accidentally removed as a contributor so didn't receive the notifications.

This makes sense to me! I didn't think of that use case, you'd generally get notified as the worker would shutdown if I understand correctly? But additional information is all good!

@aquamatthias
Copy link
Contributor Author

@markglh Exactly. You can see one use case that I had in mind in #33 in the Akka Stream Source.
If a lease is lost I would like to throw away all buffered messages of this shard.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants