From 42e9f27a669fc4193eefbf3ae0ac0a4a37474634 Mon Sep 17 00:00:00 2001 From: Youssef Date: Tue, 29 Oct 2024 10:09:40 -0400 Subject: [PATCH 1/5] Add check for selected reporting id in generate bid output --- spec.bs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/spec.bs b/spec.bs index 937333978..cc9f547d5 100644 --- a/spec.bs +++ b/spec.bs @@ -5198,6 +5198,9 @@ To convert GenerateBidOutput to generated bid given a {{GenerateBidOu 1. Set |bid|'s [=generated bid/ad descriptor=] to |adDescriptor|. 1. Set |bid|'s [=generated bid/bid ad=] to |bidAd|. 1. If |generateBidOutput|["{{GenerateBidOutput/selectedBuyerAndSellerReportingId}}"] [=map/exists=]: + 1. If |bidAd|'s [=interest group ad/selectable buyer and seller reporting IDs=] does not + [=list/contain=] |generateBidOutput|["{{GenerateBidOutput/selectedBuyerAndSellerReportingId}}"], + return failure. 1. Set |bid|'s [=generated bid/selected buyer and seller reporting ID=] to |generateBidOutput|["{{GenerateBidOutput/selectedBuyerAndSellerReportingId}}"]. 1. If |generateBidOutput|["{{GenerateBidOutput/adComponents}}"] [=map/exists=]: From e9e6586d661dc16e9979165b626588f566a703b1 Mon Sep 17 00:00:00 2001 From: Youssef Date: Tue, 29 Oct 2024 10:16:03 -0400 Subject: [PATCH 2/5] fixed indents --- spec.bs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec.bs b/spec.bs index cc9f547d5..0230e9318 100644 --- a/spec.bs +++ b/spec.bs @@ -5199,8 +5199,8 @@ To convert GenerateBidOutput to generated bid given a {{GenerateBidOu 1. Set |bid|'s [=generated bid/bid ad=] to |bidAd|. 1. If |generateBidOutput|["{{GenerateBidOutput/selectedBuyerAndSellerReportingId}}"] [=map/exists=]: 1. If |bidAd|'s [=interest group ad/selectable buyer and seller reporting IDs=] does not - [=list/contain=] |generateBidOutput|["{{GenerateBidOutput/selectedBuyerAndSellerReportingId}}"], - return failure. + [=list/contain=] |generateBidOutput|["{{GenerateBidOutput/selectedBuyerAndSellerReportingId}}"], + return failure. 1. Set |bid|'s [=generated bid/selected buyer and seller reporting ID=] to |generateBidOutput|["{{GenerateBidOutput/selectedBuyerAndSellerReportingId}}"]. 1. If |generateBidOutput|["{{GenerateBidOutput/adComponents}}"] [=map/exists=]: From ddd87ef870df2f46ef04dd38aae589a110d57b0a Mon Sep 17 00:00:00 2001 From: Youssef Date: Tue, 29 Oct 2024 10:21:07 -0400 Subject: [PATCH 3/5] add null check --- spec.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec.bs b/spec.bs index 0230e9318..fa46a7ea9 100644 --- a/spec.bs +++ b/spec.bs @@ -5198,7 +5198,7 @@ To convert GenerateBidOutput to generated bid given a {{GenerateBidOu 1. Set |bid|'s [=generated bid/ad descriptor=] to |adDescriptor|. 1. Set |bid|'s [=generated bid/bid ad=] to |bidAd|. 1. If |generateBidOutput|["{{GenerateBidOutput/selectedBuyerAndSellerReportingId}}"] [=map/exists=]: - 1. If |bidAd|'s [=interest group ad/selectable buyer and seller reporting IDs=] does not + 1. If |bidAd|'s [=interest group ad/selectable buyer and seller reporting IDs=] is null, or does not [=list/contain=] |generateBidOutput|["{{GenerateBidOutput/selectedBuyerAndSellerReportingId}}"], return failure. 1. Set |bid|'s [=generated bid/selected buyer and seller reporting ID=] to From 563e5a3f6d1dbae8b5371326d5bbec8d506dd952 Mon Sep 17 00:00:00 2001 From: Youssef Date: Tue, 29 Oct 2024 10:57:26 -0400 Subject: [PATCH 4/5] Add to estimated size --- spec.bs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/spec.bs b/spec.bs index fa46a7ea9..4b848f26a 100644 --- a/spec.bs +++ b/spec.bs @@ -5896,6 +5896,9 @@ The estimated size of an [=interest group=] |ig| 1. The [=string/length=] of |ad|'s [=interest group ad/buyer reporting ID=] if the field is not null. 1. The [=string/length=] of |ad|'s [=interest group ad/buyer and seller reporting ID=] if the field is not null. + 1. If |ad|'s [=interest group ad/selectable buyer and seller reporting IDs=] is not null, + [=list/for each=] |id| of it: + 1. The [=string/length=] of |id|. 1. If |ad|'s [=interest group ad/allowed reporting origins=] is not null, [=list/for each=] |origin| of it: 1. The [=string/length=] of the [=serialization of an origin|serialization=] of |origin|. From fe6ef342233af256b96bd550282eb86c992be580 Mon Sep 17 00:00:00 2001 From: Youssef Date: Tue, 29 Oct 2024 10:59:45 -0400 Subject: [PATCH 5/5] add missing space --- spec.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec.bs b/spec.bs index 4b848f26a..009618bb8 100644 --- a/spec.bs +++ b/spec.bs @@ -2165,7 +2165,7 @@ To convert to an AuctionAd sequence given a [=list=]-or-null |ads|: 1. [=map/Set=] |adIDL|["{{AuctionAd/renderURL}}"] to the [=URL serializer|serialization=] of |ad|'s [=interest group ad/render url=]. 1. If |ad|'s [=interest group ad/selectable buyer and seller reporting IDs=] is not null: - 1.[=map/Set=] |adIDL|["{{AuctionAd/selectableBuyerAndSellerReportingIds}}"] to + 1. [=map/Set=] |adIDL|["{{AuctionAd/selectableBuyerAndSellerReportingIds}}"] to |ad|'s [=interest group ad/selectable buyer and seller reporting IDs=]. 1. If |ad|'s [=interest group ad/buyer and seller reporting id=] is not null then [=map/set=] |adIDL|["{{AuctionAd/buyerAndSellerReportingId}}"] to