Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec: dataVersion argument to "Score and rank a bid" is often missing. #1234

Open
MattMenke2 opened this issue Jul 24, 2024 · 0 comments
Open
Labels
spec Relates to the spec

Comments

@MattMenke2
Copy link
Contributor

There are 4 calls to score and rank a bid (2 for component auctions, 1 for additional bids, 1 for bids generated by the same level auction). The first 3 calls appear to be missing a dataVersion parameter - they go from null to auctionLevel. I believe the null is the "directFromSellerSignalsForSeller" parameter, not a null dataVersion. It's possible I'm wrong, and they're actually missing the "directFromSellerSignalsForSeller" parameter. The previous parameter in all calls is "decisionLogicFetcher", so it's definitely one of those two that's missing.

@JensenPaul JensenPaul added the spec Relates to the spec label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec Relates to the spec
Projects
None yet
Development

No branches or pull requests

2 participants