-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Behavior for performance.getEntries() #223
Comments
Is it even intended spec behavior that Navigation Timing is a loophole around directive stripping from the URL, or should it be filed as a Chromium bug? |
That's a good question I hadn't looked into yet. Per https://w3c.github.io/navigation-timing/#marking-navigation-timing it's a straight up bug, but it's probably the responsibility of this effort to ensure test coverage which this issue can track. Hopefully @bokand or @noamr is willing to file the bug but I can also do it if that would help. |
It's a known Chrome bug that I totally forgot about when I went on parental leave :( See my comment 14: The navigation timing name should be the same as the document URL. |
Yeah, I think, per-spec, the fragment directive shouldn't be exposed in navigation timing; that's a Chrome bug. But I've heard in a couple of places that developers are using this (e.g. the chrome bug, twitter thread). It seems some found it useful to be able to add info to a URL that's guaranteed not to interfere with the page. Perhaps we could add an API to enable this use case in a structured way? See also #160 (comment) |
Not sure this is great privacy-wise. I don't expect pages I navigate to via some text search to be able to tell what search term I used etc. The structured API to do this is perhaps standard query variables? |
The nice thing about providing a structured API is that we could, e.g., prevent exposing content for a sensitive directive like (To be clear, the content in the
Speculating but I think the fact that this will cause a new request, and include the parameters in the request, is probably the reason people were using the fragment. You'd also be relying on the server not choking on the unexpected query params. |
In any case, to be clear, making this web-exposable would be a new conversation and |
See #128 for conversation about exposing text fragment to the page, with a lot of privacy-related conversation on the mozilla standards position. @annevk you were actually quite active on that one seems like :) Apparently some existing content relies on the |
The API questions should probably be discussed in their relevant issues. Resolving #217 might help with some of them as perhaps the Navigation API should be an entry point. What mainly concerns me about reading the fragment directive is consistency. It seems problematic that access to identifiers is conditional and might change in the future (e.g., if we decide another directive also needs to be hidden from script). |
It seems that with
Chrome at least is more selective about what it ends up stripping from the URL.
It seems to me that should be consistent with
document.URL
.The text was updated successfully, but these errors were encountered: