Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with ImageData extension #62

Open
weinig opened this issue Apr 30, 2021 · 0 comments
Open

Issues with ImageData extension #62

weinig opened this issue Apr 30, 2021 · 0 comments

Comments

@weinig
Copy link

weinig commented Apr 30, 2021

The current proposal has the following extension to the ImageData interface:

partial interface ImageData {
  constructor(unsigned long sw, unsigned long sh, optional ImageDataSettings);
  constructor(ImageDataArray data, unsigned long sw, unsigned long sh, optional ImageDataSettings);
  readonly ImageDataSettings getImageDataSettings();
  readonly attribute ImageDataArray data;
};

There are few issues here.

  1. Partial interfaces cannot define constructors (though I don't exactly remember why this is a requirement, the grammar does not allow it). I think you will want to define this by completely re-declaring the ImageData interface.
  2. The readonly prefix on the getImageDataSettings() operation is invalid. It should just be removed.
  3. The type ImageDataArray appears in two places and is undefined. This was probably from an earlier draft where non-8-bit backing stores were supported but should now be removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant