Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to rename "anonymous" to "credentialless" or some such #5

Closed
smaug---- opened this issue Jun 2, 2022 · 14 comments
Closed

Comments

@smaug----
Copy link

smaug---- commented Jun 2, 2022

Seems like the spec doesn't try to create really anonymous iframes (anonymous feels rather strong word) but rather just credentialless.
The iframes aren't blocked from accessing each others or anything like that and they can access iframes which aren't anonymous.

(this was discussed during a Mozilla meeting on what we think of the proposal)

@ArthurSonzogni
Copy link
Collaborator

Thanks so much for taking the time to look into AnonymousIframe proposal!

This question makes sense. Initially, it used to be credentials=XXX. Then in a similar message than yours, but in the opposite direction, it was proposed to switch toward anonymous. Here is the rational:
camillelamy/explainers#20

What would be your prefered direction, without falling into the previous drawbacks?

@ArthurSonzogni
Copy link
Collaborator

@smaug---- , @sefeng211
Given camillelamy/explainers#20, do you think "anonymous" is good enough? Or do you believe something else would be a better fit?

@smaug----
Copy link
Author

credentialless wouldn't have the drawbacks

@smaug----
Copy link
Author

Though, #4 may require something more complicated.

(In general I'm rather worried about adding yet another allow/disallow/tweak-features type of attribute to iframe and not reuse existing ones)

@ArthurSonzogni
Copy link
Collaborator

@smaug---- I would be happy to switch to a different attribute. Do you have some proposition?

@smaug----
Copy link
Author

credentialless. camillelamy/explainers#20 even suggested something similar 'clean-credentials'

But I'm not yet convinced we want yet another attribute to control how the iframe behaves. One might want to use sandbox attribute.

@ArthurSonzogni
Copy link
Collaborator

ArthurSonzogni commented Aug 2, 2022

Yes

<iframe credentialless>

is nice too. We can switch again if you think this is better. What others are thinking? (@mikewest, @camillelamy, @annevk)

If we got this way, the windows.anonymouslyFramed would also need a rename. Not sure how.

But I'm not yet convinced we want yet another attribute to control how the iframe behaves. One might want to use sandbox attribute.

Okay, I will continue on: mozilla/standards-positions#628 (comment)

@RByers
Copy link
Member

RByers commented Nov 1, 2022

Any update? Seems like some resolution to this issue should block shipping, right?

@camillelamy
Copy link
Contributor

I am happy with <iframe credentialless>. windows.anonymouslyFramed could become window.credentialless maybe?

@annevk
Copy link

annevk commented Nov 8, 2022

The one nit I have with credentialless is that in the context of COEP it only applies to "no-cors" whereas here it would cast a wider net. We'd want to explicitly document that difference.

@ArthurSonzogni
Copy link
Collaborator

Similar to #1 (window.anonymous usage in the wild)
I checked window.credentialless usage in the http archive:

#standardSQL
SELECT page, url
FROM `httparchive.response_bodies.2022_10_01_mobile`
WHERE STRPOS(body, 'window.credentialless') > 0

It returned no occurrence. It seems this won't be an issue using this name.

@ArthurSonzogni
Copy link
Collaborator

Also pleased with the rename. I will update the explainer/spec/chrome.

The one nit I have with credentialless is that in the context of COEP it only applies to "no-cors" whereas here it would cast a wider net. We'd want to explicitly document that difference.

Thanks for mentioning it! I will make sure to add paragraph while updating it.

ArthurSonzogni added a commit that referenced this issue Nov 15, 2022
- <iframe anonymous> becomes <iframe credentialless>
- `window.anonymouslyFramed` becomes `window.credentialless`
- Add a section explaining the difference with COEP:credentialless

See:#5
ArthurSonzogni added a commit that referenced this issue Nov 15, 2022
- <iframe anonymous> becomes <iframe credentialless>
- `window.anonymouslyFramed` becomes `window.credentialless`
- Add a section explaining the difference with COEP:credentialless

See:#5
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 17, 2022
This addresses:
WICG/anonymous-iframe#5

This renames:
- <iframe anonymous> into <iframe credentialless>
- window.anonymouslyFramed into window.credentialless

Before merging this patch, I will make sure to give
sufficient prior notice to Google Display Ads who are
doing some large scale experiment with the OT, which
this change might affect.

Change-Id: Idb53cfc059f2e0232903a10409f4d349e85498f8
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 18, 2022
This addresses:
WICG/anonymous-iframe#5

This renames:
- <iframe anonymous> into <iframe credentialless>
- window.anonymouslyFramed into window.credentialless

Before merging this patch, I will make sure to give
sufficient prior notice to Google Display Ads who are
doing some large scale experiment with the OT, which
this change might affect.

Change-Id: Idb53cfc059f2e0232903a10409f4d349e85498f8
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 18, 2022
This addresses:
WICG/anonymous-iframe#5

This renames:
- <iframe anonymous> into <iframe credentialless>
- window.anonymouslyFramed into window.credentialless

Before merging this patch, I will make sure to give
sufficient prior notice to Google Display Ads who are
doing some large scale experiment with the OT, which
this change might affect.

Change-Id: Idb53cfc059f2e0232903a10409f4d349e85498f8
aarongable pushed a commit to chromium/chromium that referenced this issue Nov 22, 2022
This addresses:
WICG/anonymous-iframe#5

This renames:
- <iframe anonymous> into <iframe credentialless>
- window.anonymouslyFramed into window.credentialless

Before merging this patch, I will make sure to give
sufficient prior notice to Google Display Ads who are
doing some large scale experiment with the OT, which
this change might affect.

Change-Id: Idb53cfc059f2e0232903a10409f4d349e85498f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4016836
Commit-Queue: Mike West <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Reviewed-by: Mike West <[email protected]>
Auto-Submit: Arthur Sonzogni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1074551}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 22, 2022
This addresses:
WICG/anonymous-iframe#5

This renames:
- <iframe anonymous> into <iframe credentialless>
- window.anonymouslyFramed into window.credentialless

Before merging this patch, I will make sure to give
sufficient prior notice to Google Display Ads who are
doing some large scale experiment with the OT, which
this change might affect.

Change-Id: Idb53cfc059f2e0232903a10409f4d349e85498f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4016836
Commit-Queue: Mike West <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Reviewed-by: Mike West <[email protected]>
Auto-Submit: Arthur Sonzogni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1074551}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 22, 2022
This addresses:
WICG/anonymous-iframe#5

This renames:
- <iframe anonymous> into <iframe credentialless>
- window.anonymouslyFramed into window.credentialless

Before merging this patch, I will make sure to give
sufficient prior notice to Google Display Ads who are
doing some large scale experiment with the OT, which
this change might affect.

Change-Id: Idb53cfc059f2e0232903a10409f4d349e85498f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4016836
Commit-Queue: Mike West <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Reviewed-by: Mike West <[email protected]>
Auto-Submit: Arthur Sonzogni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1074551}
@ArthurSonzogni
Copy link
Collaborator

Okay. So this is mostly done:

  1. @annevk comment 5 addressed here
  2. WPT tests rename: patch
  3. Spec rename: Rename anonymous iframe into iframe credentialless #13

What is left:

  • Rename the repository
  • Rename the WPT test directory
  • Same as in (3), but in the HTML/FETCH/STORAGE/... PRs.

@mikewest also asked what about using window.credentiallesslyFramed instead window.credentialless.

I wonder if there's the potential for confusion between this and COEP: credentialless... Should we call this something like credentiallesslyFramed?

I don't really have a strong opinion.

@ArthurSonzogni
Copy link
Collaborator

I am done updating the PRs. Only the HTML required an update.
I think we can mark it as closed. Renaming the repository and the WPT directory is on its way

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Dec 11, 2022
Automatic update from web-platform-tests
Rename anonymous iframe.

This addresses:
WICG/anonymous-iframe#5

This renames:
- <iframe anonymous> into <iframe credentialless>
- window.anonymouslyFramed into window.credentialless

Before merging this patch, I will make sure to give
sufficient prior notice to Google Display Ads who are
doing some large scale experiment with the OT, which
this change might affect.

Change-Id: Idb53cfc059f2e0232903a10409f4d349e85498f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4016836
Commit-Queue: Mike West <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Reviewed-by: Mike West <[email protected]>
Auto-Submit: Arthur Sonzogni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1074551}

--

wpt-commits: 26bd77a5f8b9cc70e897fc5eeecb9efe1a228aec
wpt-pr: 37003
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Dec 14, 2022
Automatic update from web-platform-tests
Rename anonymous iframe.

This addresses:
WICG/anonymous-iframe#5

This renames:
- <iframe anonymous> into <iframe credentialless>
- window.anonymouslyFramed into window.credentialless

Before merging this patch, I will make sure to give
sufficient prior notice to Google Display Ads who are
doing some large scale experiment with the OT, which
this change might affect.

Change-Id: Idb53cfc059f2e0232903a10409f4d349e85498f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4016836
Commit-Queue: Mike West <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Reviewed-by: Mike West <[email protected]>
Auto-Submit: Arthur Sonzogni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1074551}

--

wpt-commits: 26bd77a5f8b9cc70e897fc5eeecb9efe1a228aec
wpt-pr: 37003
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants