Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use command-preview in nightly #2

Open
ObserverOfTime opened this issue Sep 16, 2022 · 5 comments
Open

Use command-preview in nightly #2

ObserverOfTime opened this issue Sep 16, 2022 · 5 comments

Comments

@ObserverOfTime
Copy link

Neovim nightly supports inccommand previews in user commands.
See: https://neovim.io/doc/user/map.html#:command-preview

@Vonr
Copy link
Owner

Vonr commented Sep 16, 2022

Yeah it's what initially inspired me to add preview mode but unfortunately align.nvim doesnt use a command to run any functions, and instead uses a (poorly made) custom prompt, which is not usable with that feature as far as i know.

@ObserverOfTime
Copy link
Author

Converting the functions to commands with arguments shouldn't be hard.
Implementing the preview handler would probably be the harder part.

@Vonr
Copy link
Owner

Vonr commented Sep 16, 2022

I'll try to look into it but I have taken an internship and don't have nearly as much free time as I would like. For now, if anyone else is interested they can open a pull request to implement it, I'll be more likely to accept it if it doesn't break the current api, though thats unlikely without duplication.

@ObserverOfTime
Copy link
Author

You can always merge it in another branch. I might try to implement it myself.

@Vonr
Copy link
Owner

Vonr commented Sep 16, 2022

Yep, that works too, might have to edit the master branch's README to direct people to the new one though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants