-
Notifications
You must be signed in to change notification settings - Fork 0
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestions and Issues Regarding the VocaDB Player (Non-Beta) #159
Comments
I just don't have motivation to implement most of these features, because I'd like to concentrate on implementing more useful and/or important features. I already spent much more time on thinking about UI/UX than you did (making several experiments, reading books and blog posts, using multiple media players and websites and etc.), and I'm quite happy and satisfied with the current implementation. Actually, the "Show/Hide bottom bar" feature is not intended to be used extensively. I'm quite sure you'll be accustomed to the new bottom bar before the permanent option being provided. This can be compared to the fact that the top and side bars can't be closed in the first place. I'd rather suggest you buy a 56-pixel-taller (which is the height of the bottom bar) display than you have, which would solve your space issue elegantly. For future reference, it's not allowed to display overlays, frames, or other visual elements in front of any part of a YouTube embedded player, including player controls. Try hard refresh by pressing Ctrl+F5 if you get an "Service Unavailable" error when loading the page. Can you please open an issue on VocaDB/nostalgic-diva instead? We must "lazy-load" videos to prevent cookies from being set unless an embedded video is played. Search the web for "cookie consent banner", if you're curious why we need to do like this (Spoiler: this was one of the main motivations to implement the bottom bar and the mini player). I'm not sure if there is a way to obtain a video preview without loading a video. The implementation of react-player would help as a reference. Of course, as always, pull requests are welcome if someone else wants to implement these features. Quote from riipah's blog post:
Read each blog post 39 times. |
The issue with the bottom bar isn't space, it's that it's a highly-attention grabbing UI element with a strong contrast to everything else. It's distracting, and I can't focus with it around. It would be very helpful if we could turn it persistently off for site accessibility. I know I'm not the only person with issues here, either -- a person on the Discord mentioned that they had wanted to start a similar thread to mine, but are having difficulties posting here. As such, while you may have "spent more time thinking about UI" than I ever have, because of my specific disabilities, I tend to notice certain accessibility flaws before other people. By working together, we can make a better product.
Ah, Youtube. It might be best to not have the bottom thumbnail appear at all if the bar is closed, then, or perhaps a button to the side of the thumbnail (not on it, beside it) could work.
I'll do that in a bit. EDIT: Done.
That's fair. I quite appreciate the explanation, so thank you. EDIT: Removed the numbers and added in quotes. I wasn't expecting Github to automatically convert my 1/4/6/7 to 1/2/3/4. |
First of all, I'm not against making it possible to turn the bottom bar persistently off, and I understand that there are some people who tend to notice certain accessibility flaws before other people. I just don't have resources to implement it alone, because we have more important and urgent issues to resolve first. It only takes one hour or two to make a suggestion, but it takes 10-20 hours, or even more, (unpaid) to implement it. As I said, "pull requests are welcome". I'll lock the conversation for now. P.S. Thanks for opening an issue at VocaDB/nostalgic-diva#2. |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
This is something of a continuation of riipah's previous thread, as you can probably tell from the title. ;3 Now that it's out of beta, it's a bit easier to see how the player actually functions during common VDB usage, and while it's definitely functional, it's a bit strange.
When I refresh, the menu pops back despite having been closed prior. It also appears in a new tab, despite the original tab having the menu toggled off. Could we possibly make the on/off toggle more permanent? I'd like it to stay closed personally, instead of reappearing during refreshes or through new tabs.
Related to the above, it might make sense to have a temporary close button on the hamburger menu on the bar, and a permanent close button in the "My Account" menu (where the close button currently is). Admittedly, I'm not sure where the first reopen button would be.
Closing the bottom bar doesn't remove the playing/previous video thumbnail at the bottom right of the screen, while it really should. The videos look fine with the bar, but they're quite awkward without it.
Relatedly, you can't close the bottom right video without the bar open.
Also, switching between Youtube/Soundcloud/etc versions of the same video opens the bottom right video; I'm not sure if this is a good idea? Might want to make this a toggle.
It seems unable to play age-restricted Youtube songs (tested on the original ME!ME!ME!). I'm not sure if this is fixable on our end.
The video image (seen in screenshot) is...weird, to say the least. I have it set so that Youtube's my preferred platform here, and while that wasn't an issue before, it's certainly causing some oddities here. First, as the screenshot shows, the image/video defaults to Youtube even when the Youtube link is unavailable. Second, when I click on a different version (such as Soundcloud), the image/embed doesn't actually change until I click on the little play button. Notably, everything else (Soundcloud -> NicoNico, for instance) swaps videos/images immediately, but they all seem to default to the Youtube embed? It's strange.
The text was updated successfully, but these errors were encountered: