Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AloTransform parameters sampling applied twice #358

Open
many28 opened this issue Jul 21, 2023 · 0 comments
Open

AloTransform parameters sampling applied twice #358

many28 opened this issue Jul 21, 2023 · 0 comments

Comments

@many28
Copy link

many28 commented Jul 21, 2023

In AloTransform init function, we initialize the parameters by calling the sample_params() function :

self.sample_params()

However it's already called in the _call_() function, for each scenario case of the input frames structure:

def __call__(self, frames: Union[Mapping[str, Frame], List[Frame], Frame], **kwargs):

Which leads to double initialization of the parameters for each instance, if the parameters are chosen randomly, it may rise conflicts of using the two different values of the parameters in the same appliance of the transform, possible inheritance conflicts between other transform classes that come from AloTransform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant