Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some JVM indexes fail when passed without specifying the distro on aarch64 #3396

Open
Gedochao opened this issue Dec 30, 2024 · 0 comments
Open
Labels
arch:aarch64 coursier Issues tied with coursier integration. jvm Issues tied to the JVM platform missing feature Something should have been implemented, but wasn't.

Comments

@Gedochao
Copy link
Contributor

Gedochao commented Dec 30, 2024

I'm not yet 100% sure where should we fix it.
Technically speaking, cs defaults to adoptium everywhere, so the error it fails with is valid...

cs java-home --jvm 16 --architecture arm64
# JVM 16 not found in index: No adoptium version matching '1.16+' found

I don't think we should fail in Scala CLi under the same circumstances, however.
Perhaps we should just log that the index wasn't found for adoptium, and fallback to smth else (i.e. zulu)...

Originally posted by @Gedochao in #3375 (comment)

So some JVM indexes (i.e. 16 for aarch64) aren't available for adoptium, which is the default for coursier.
We should do one of the following:

  • log a warning and fallback to another distro (i.e. zulu)
  • keep failing from Scala CLI, but provide alternatives in the error message
@Gedochao Gedochao added jvm Issues tied to the JVM platform missing feature Something should have been implemented, but wasn't. coursier Issues tied with coursier integration. labels Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch:aarch64 coursier Issues tied with coursier integration. jvm Issues tied to the JVM platform missing feature Something should have been implemented, but wasn't.
Projects
None yet
Development

No branches or pull requests

1 participant