Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loading a link doesn't come up with the same thing? #753

Open
nsteinme opened this issue Nov 6, 2024 · 3 comments
Open

loading a link doesn't come up with the same thing? #753

nsteinme opened this issue Nov 6, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@nsteinme
Copy link

nsteinme commented Nov 6, 2024

I generated this link about two weeks ago, at which time it produced this layout:

image

but now upon clicking it, I think you will see this, where they are off to the side and I think not as deep. The selected brain regions are also deselected, if it's intended that those are part of the link. I can't tell from me end whether this is a bug with the links or whether there was a change recently that broke link compatibility, but I assume it is one of those two thing?

image

@nsteinme nsteinme added the bug Something isn't working label Nov 6, 2024
@dbirman
Copy link
Member

dbirman commented Nov 6, 2024

Definitely a bug that's changing something. Thanks for flagging this!

@kjy5
Copy link
Member

kjy5 commented Nov 11, 2024

Regions getting deselected is probably a bug, but the location of the probes seems right. Referencing what I said in #752 it looks like the reference coordinate is back at Bregma in the second picture whereas in the first picture, it was off somewhere else.

It's still probably a bug that this isn't loaded correctly, but the probes are in the right relative positions (I think).

@dbirman
Copy link
Member

dbirman commented Nov 11, 2024

The bug is that reference coordinate information isn't being saved and/or loaded properly, and I think the defaults are also messed up somehow. All of this should be fixed by the SceneData changes, so I probably won't patch this before getting that rolled out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants