Skip to content
This repository has been archived by the owner on Sep 3, 2021. It is now read-only.

Error in package ID calculation in Rate.php #58

Open
mgcobblestone opened this issue Feb 23, 2021 · 0 comments
Open

Error in package ID calculation in Rate.php #58

mgcobblestone opened this issue Feb 23, 2021 · 0 comments

Comments

@mgcobblestone
Copy link

Hi,
There appears to be an error in the logic that generates the package IDs in Rate.php

Line 75 should read:

$packageId = $id !== null ? $id : ((count($this->packages['Package']) + 1));

instead of

$packageId = $id !== null ? $id : ((count($this->packages) + 1));

Currently, for shipments containing more than 2 packages, everything after the 2nd package gets an ID of 2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant