Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filename not so nice #29

Open
magentix98 opened this issue Apr 4, 2016 · 1 comment
Open

Filename not so nice #29

magentix98 opened this issue Apr 4, 2016 · 1 comment

Comments

@magentix98
Copy link

Hi,
I have successfully installed the extension. Now I get image urls like this:

media/catalog/product/cache/1/small_image/210x/9df78eab33525d08d6e5fb8d27136e95/i/m/img_1335/Massageliege-mit-6cm-Polsterung-+-Rollen,-Hocker-beige-400203-20.jpg

the last part is productname + sku + index. Works as expected.
but what about the path: media/catalog/product/cache/1/small_image/210x/9df78eab33525d08d6e5fb8d27136e95/i/m/img_1335/
That does not look very "friendly".
Is there something i can so to get a more simple path?

@beejhuff
Copy link

beejhuff commented Aug 6, 2016

Sadly the portion of the folder structure you're referring to in this issue is not actually affected nor is editable by the plugin.

That is an ID generated to uniquely identify a store when it is created. The first one is generated when you run the installation utility and the default store is created. Additional stores can also created in the admin utility and those admittedly unfriendly identifiers are created to ensure that there is very little chance that those values are either "guessable" (almost impossible) or likely to be close to each other when multiple stores are setup.

There are many places in the folder and file path where that value is used to make sure there is no risk that similar folder names ever lap. In the particular case you describe that unique value is used to ensure that the folder cache of images, js, css, whatever is generated has no chance of colliding with another store's local folder cache.

That could result in confusion for users and administrators on the system - they could be viewing a page on store-1 and instead see a cached object that should only be displayed on store-2 because the ID was changed to a value that was easy to guess or manually changed.

It could also break core functionality if you didn't ensure there was enough entropy used in your generation function there is a of value collision in the output of multiple calls to the function. This could theoretically result in multiple stores being created with the same ID and breaking unique constraints across the entire MySQL schema where this ID used as part of a composite FK reference.

Class: Mage_Core_Model_Store

File: app/code/core/Mage/Core/Model/Store.php

It is perhaps possible to write another extension to override that default method in the base class or extend this extension to perform that behavior. Keep in mind that it used as unqieu valur for a long time However given this is currently used a unique identifier for the default store and if this function

NOTE: _I know @Vinai established the use case for the plugin as a way to create attractive file names for users who download images what have names automatically generated, which it is undoubtedly more appealing to shoppers if they are downloading images from your catalog.

The far more common benefit I've used this extension is for SEO enhancement since google returns search results that contain images with search terms used in asset name far more higher in your search results and it results genally in higher conversion rates and better sales _

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants