Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve robustness of the input parser. #21

Open
xileF1337 opened this issue Dec 4, 2019 · 0 comments
Open

Improve robustness of the input parser. #21

xileF1337 opened this issue Dec 4, 2019 · 0 comments

Comments

@xileF1337
Copy link

Problem description

The input parser is very sensitive to whitespace (errors). A single, empty line at the end of the input causes it to choke on the input. Some of the columns of the input files cannot be parsed if they are separated by multiple spaces, however, structure and energy of the built-in "small example" are sometimes separated by two spaces. Allowing multiple spaces would allow to format the input in a more human-readable manner.

Additionally, there is no reporting of parser errors to the user. The visualization simply gets stuck at the "Loading..." stage.

Expected behaviour

  1. The parser should skip over blank lines.
  2. The parser should separate the columns on any consecutive whitespace, be it a single space, multiple spaces, tabs etc.
  3. There should be an error message when encountering parsing errors, ideally telling the user which part of the file caused the error and / or how it should actually look like.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant