Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replacing Icons for Android not reflecting. Suspect .xml file #950

Closed
tapizquent opened this issue Jan 28, 2024 · 2 comments
Closed
Labels
bug Something isn't working as expected

Comments

@tapizquent
Copy link

Description
I have adjusted and changed all the icons from the mipmap folders for all three flavors (dev, stg, and prod) but these don't reflect once the app if built.

I have a suspicion that the launch icon is being loaded from an .xml file called ic_launch_image.xml instead of the images provided.

Could you please provide a bit more infor around changing the icon properly?

@tapizquent tapizquent added the bug Something isn't working as expected label Jan 28, 2024
@tapizquent
Copy link
Author

For reference, yes, that was actually the problem. I removed the ./android/app/src/development/res/mipmap-anydpi-v26/ic_launcher_round.xml and ./android/app/src/development/res/mipmap-anydpi-v26/ic_launcher.xml, and just added the andoird:roundIcon property to the manifest file.

Changing the images only will not work as most phones seem to build from the xml file instead.

Please would be nice to have some more clear docs around this, given that the icon is set with the VeryGood icons

@alestiago
Copy link
Contributor

Hi @tapizquent thanks for opening the issue!

Yes, I agree that we should improve the documentation around the icons. There is an open issue #768. If you would like to write some documentation we can then review your Pull Request.

For now, I'll be closing this issue as a duplicate if you would like to contribute feel free to drop a comment on #768 asking us to assign you.

@alestiago alestiago closed this as not planned Won't fix, can't repro, duplicate, stale Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

2 participants