Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No sound gets shared in screenshare #34

Open
3 tasks done
milantonin opened this issue Nov 9, 2024 · 16 comments
Open
3 tasks done

No sound gets shared in screenshare #34

milantonin opened this issue Nov 9, 2024 · 16 comments
Assignees
Labels
bug Something isn't working

Comments

@milantonin
Copy link

✍️ Bug Description

In my screenshare, people cant hear my systems sound but instead my microphone(i tried the Venmic setting(Microphone Workaround)) it doesnt matter if audio source is set to only browser (or any other application) or entire system.
so the problem is Venmic

🔁 Steps to reproduce

im not 100% sure if that recreates it

click on [share your screen]
chose an application
set audio source to [Entire System]
click on [Open Audio Settings]
mark/unmark [Microphone Workaround]

🗒️ Debug Output

[2024-11-09 15:02:00.378] [venmic] [warning] [patchbay] (link) failed to link 159 (mic) -> 59 (node): link-factory: can't link ports 59 and 159: File exists
[2024-11-09 15:02:00.379] [venmic] [warning] [patchbay] (link) failed to link 107 (mic) -> 58 (node): link-factory: can't link ports 58 and 107: File exists
[2024-11-09 15:02:00.380] [venmic] [warning] [patchbay] (link) failed to link 159 (mic) -> 77 (node): link-factory: can't link ports 77 and 159: File exists
[2024-11-09 15:02:00.380] [venmic] [warning] [patchbay] (link) failed to link 107 (mic) -> 76 (node): link-factory: can't link ports 76 and 107: File exists
[2024-11-09 15:02:00.381] [venmic] [warning] [patchbay] (link) failed to link 159 (mic) -> 140 (node): link-factory: can't link ports 140 and 159: File exists
[2024-11-09 15:02:00.382] [venmic] [warning] [patchbay] (link) failed to link 107 (mic) -> 137 (node): link-factory: can't link ports 137 and 107: File exists
[2024-11-09 15:02:00.383] [venmic] [warning] [patchbay] (link) failed to link 159 (mic) -> 152 (node): link-factory: can't link ports 152 and 159: File exists
[2024-11-09 15:02:00.383] [venmic] [warning] [patchbay] (link) failed to link 107 (mic) -> 136 (node): link-factory: can't link ports 136 and 107: File exists
[2024-11-09 15:02:00.384] [venmic] [warning] [patchbay] (link) failed to link 159 (mic) -> 143 (node): link-factory: can't link ports 143 and 159: File exists
[2024-11-09 15:02:00.385] [venmic] [warning] [patchbay] (link) failed to link 107 (mic) -> 145 (node): link-factory: can't link ports 145 and 107: File exists

❔ Expected behavior

I expect it to capture my systems sound and output that sound the the screenshare instead of outputting my microphone sound (I expect the Microphone Workaround to work)

👀 Screenshots

Screenshot from 2024-11-09 14-47-59

📦 Vesktop Version

1.5.3

🖥️ Distribution

Zorin OS 17.2

✅ I confirm that...

  • I have collected all the required information and read all the comments in this document
  • I searched for an existing bug report for this issue
  • the problem does occur with the reproduction steps I provided
@milantonin milantonin added the bug Something isn't working label Nov 9, 2024
@Curve
Copy link
Member

Curve commented Nov 9, 2024

Please attach the full debug log - not only a portion of it.

Also, was the provided screenshot captured with the "microphone workaround" setting turned on?

@Vencord Vencord deleted a comment from Covkie Nov 9, 2024
@milantonin
Copy link
Author

Please attach the full debug log - not only a portion of it.

Also, was the provided screenshot captured with the "microphone workaround" setting turned on?

this should be the full log
venmic1.log

this one is with Microphone workaround turned off
micWAoff

this one is with Microphone workaround turned on
micWAon

@Curve
Copy link
Member

Curve commented Nov 10, 2024

Can you also share a screenshot of the venmic settings you are using (as found in the screenshare modal)?

The linking of all these capture ports shouldn't happen (those from the t-bone microphone). The workaround seems to be applied correctly, however, it seems like your audio setup does not respect the pipewire properties set here... I'll have to try to reproduce this.

@milantonin
Copy link
Author

Can you also share a screenshot of the venmic settings you are using (as seen in the screenshare modal)?

The linking of all these capture ports shouldn't happen (those from the t-bone microphone). The workaround seems to be applied correctly, however, it seems like your audio setup does not respect the pipewire properties set here... I'll have to try to reproduce this.

right now these
Screenshot from 2024-11-10 15-09-58

@Curve
Copy link
Member

Curve commented Nov 10, 2024

Ah, Ignore Devices and Ignore Inputs being turned off explains why the microphone is included - can you check if turning that on prevents the microphone from being linked to venmic? As for the workaround not working, I'll have to investigate

@milantonin
Copy link
Author

milantonin commented Nov 10, 2024

turning Ignore Devices and Ignore inputs on disconnects my microphone but in my stream other still hear it
Screenshot from 2024-11-10 15-21-08

@milantonin
Copy link
Author

Ok, so i tried some thing and the Chromium input-1 [RecordStream] seems to be the reason why my microphone still outputs in to the screenshare

with this others can hear me
MicOutputinstream1

with this not
MicOutputinstream0

@Curve
Copy link
Member

Curve commented Nov 10, 2024

turning Ignore Devices and Ignore inputs on disconnects my microphone but in my stream other still hear it

It correctly prevents the microphone from being linked to the venmic node - which is something you'd want in most cases.
The bigger issue at hand is that the microphone workaround doesn't work on your configuration, which results in Chromium incorrectly linking against the system microphone instead of the correct node, which in this case would be the venmic one.

This is usually fixed by telling pipewire to force the chromium node to connect to venmic. However, that doesn't seem to work on your system.

@milantonin
Copy link
Author

If i connect the [media output node] with the Chromium input-1 [RecordStream] it works (makes sense but didnt thought of it yesterday) but i dont wanna use this as a workaround forever since it has to be done manually every time you start a screenshare. I'll try to automate it, but would be nice if you could tell me your thoughts on it since im not that experienced.
image

@Curve
Copy link
Member

Curve commented Nov 11, 2024

As I said earlier, I know what the issue is and I will investigate this. Just be patient, I have a lot of things to do this week, I'll get to it soon

@littlecube23
Copy link

I also have this issue on Zorin OS.
Settings selected when screensharing
image

How audio routes as shown by Helvum
image

What I have to do to get audio to work
image

OS: Zorin OS 17.2 x86_64
Kernel: 6.8.0-51-generic
stable 358011 (433f07a) Build Override: N/A
Vencord 3243120 (Vesktop v1.5.4)
Electron 33.2.1
Chromium 130.0.6723.137

I appreciate you working on it but just thought I'd add some info as well just in case! :)

@Curve
Copy link
Member

Curve commented Jan 12, 2025

I also have this issue on Zorin OS.
Settings selected when screensharing
image

How audio routes as shown by Helvum
image

What I have to do to get audio to work
image

OS: Zorin OS 17.2 x86_64
Kernel: 6.8.0-51-generic
stable 358011 (433f07a) Build Override: N/A
Vencord 3243120 (Vesktop v1.5.4)
Electron 33.2.1
Chromium 130.0.6723.137

I appreciate you working on it but just thought I'd add some info as well just in case! :)

Are you using the microphone workaround?

@littlecube23
Copy link

littlecube23 commented Jan 12, 2025

In this post its with microphone workaround turned on. In a later post I try with it off

The settings before I hit stream
image

Stream Settings
image

What shows in QjackCTL
image

Friends cannot hear audio.

Also some more info just in case?
Server Name: PulseAudio (on PipeWire 1.0.7)
Server Version: 15.0.0

I would attach logs but I am unsure where to find them. I have vesktop installed via flatpak

@Covkie
Copy link

Covkie commented Jan 12, 2025

Disable microphone workaround?

@littlecube23
Copy link

littlecube23 commented Jan 12, 2025

Proof With Microphone Workaround Turned off
image

QjackCTL before I hit Stream Button
image

What QjackCTL shows after I hit stream button
image

Friends can still not hear. Ive verified I am not muted on their end and their stream volume is still up. They just hear me twice. Still unsure why my Microphone sends itself to a new chromium input. Theoretically only vencord-screen-share should be added right?

@littlecube23
Copy link

Added a video showing the entire process as well as attaching a log now that I figured out how to do so. I also tried this time using only my headset mic and disconnected my blue yeti. The same thing occurs with both microphone workaround and without. Below is the video

Screencast.from.2025-01-13.16-57-52.webm

Here is the log
venmic.log

Thank you again for your help in this matter. Just trying to add as much information as I can as I know remote troubleshooting can be difficult. Let me know if you need anything else!

Sorry for all the pestering!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants