Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in NFT ID Handling #51

Open
myst4 opened this issue Feb 14, 2024 · 2 comments
Open

Inconsistency in NFT ID Handling #51

myst4 opened this issue Feb 14, 2024 · 2 comments

Comments

@myst4
Copy link

myst4 commented Feb 14, 2024

Hello guys,

I am currently testing the DN404 protocol, and I've encountered inconsistencies regarding NFT IDs.
Here is the scenario:

User A and User B are participating in the protocol.
User A purchases 4 NFTs with the IDs 1, 2, 3, and 4.
User B purchases 1 NFT with the ID 5.
User A sells the NFTs with the IDs 3 and 4 as tokens on a DEX. These two IDs are burned.
User A returns to purchase another entire unit token (1 NFT) on a DEX. The new NFT is minted with the ID 6, resulting in a loss of reference to the IDs 3 and 4.

This process raises concerns about consistency in NFT ID. Shouldn't there be a mechanism in place to maintain consistency and ensure that IDs are not lost?
If I'm not mistaken, The ERC404 protocol addresses this by adding a queue for burned IDs to be minted again later, ensuring consistency with the NFT IDs

Thanks for advance

@Vectorized
Copy link
Owner

This is intentional. We want to cycle through all the token Ids.

If you want to prevent rarity sniping, make a second baseURI update after all the IDs have been cycled through once.

@Vectorized
Copy link
Owner

We might make it an option in the future to allow recycling token Ids, but we have other priorities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants