-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QuicClient.CreateStream is hardcoded to 1. #3
Labels
good first issue
Good for newcomers
Comments
Good catch. We can use a NumberSpace class instance here, it's part of QuicNet.Infrastructure. We can substitute the streamId optional parameter with a private NumberSpace in the QuicClient, and leave the streamType in place, so a client can choose whether is Uni/Bidirectional. Still, let's merge that one in, Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've changed my local version to:
public QuicStreamContext CreateStream(ulong streamId = 1, StreamType streamType = StreamType.ClientBidirectional);
in order to keep the compatibility.
The text was updated successfully, but these errors were encountered: