Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuicClient.CreateStream is hardcoded to 1. #3

Open
angedelamort opened this issue Jan 5, 2019 · 1 comment
Open

QuicClient.CreateStream is hardcoded to 1. #3

angedelamort opened this issue Jan 5, 2019 · 1 comment
Labels
good first issue Good for newcomers

Comments

@angedelamort
Copy link

I've changed my local version to:

public QuicStreamContext CreateStream(ulong streamId = 1, StreamType streamType = StreamType.ClientBidirectional);

in order to keep the compatibility.

@Vect0rZ
Copy link
Owner

Vect0rZ commented Jan 5, 2019

Good catch. We can use a NumberSpace class instance here, it's part of QuicNet.Infrastructure. We can substitute the streamId optional parameter with a private NumberSpace in the QuicClient, and leave the streamType in place, so a client can choose whether is Uni/Bidirectional.

Still, let's merge that one in,

Thanks!

@Vect0rZ Vect0rZ added the good first issue Good for newcomers label Jan 5, 2019
@Vect0rZ Vect0rZ pinned this issue Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants