Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More setState warnings #2

Open
jhen0409 opened this issue Jul 10, 2016 · 6 comments
Open

More setState warnings #2

jhen0409 opened this issue Jul 10, 2016 · 6 comments

Comments

@jhen0409
Copy link
Contributor

It seems this line will unmount JellySideMenuSvg, so setState will not work in JellySideMenuSvg.

2016-07-10 9 18 30
@VansonLeung
Copy link
Owner

Thanks, fixed

@jhen0409
Copy link
Contributor Author

@VansonLeung I don't think it's fixed, isMounted is killed in new react version, and it's not the right place. I think we should remove all listeners in componentWillUnmount for JellySideMenuSvg.

2016-07-11 5 03 38

@VansonLeung VansonLeung reopened this Jul 11, 2016
@VansonLeung
Copy link
Owner

Fixed thanks

@Rizwanjamal
Copy link

Rizwanjamal commented Aug 19, 2016 •
edited
Loading

I am recently used this module, but got warnings on every single click on Close Side Menu & when I click on open Jelly Menu it breaks the code & the animation stop working ...

image

@VansonLeung
Copy link
Owner

Thanks, will fix by tomorrow!

@VansonLeung VansonLeung reopened this Aug 19, 2016
@Rizwanjamal
Copy link

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@VansonLeung @jhen0409 @Rizwanjamal