-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onCluster not triggered upon setting streaming mode to true #50
Comments
Hi, I cannot reproduce the monotonicity violation issue. I switched to Regarding the onCluster callback: Thank you for bringing this to my attention. I'll investigate it when I find the time. |
Hi Vanilagy, I actually couldnt reproduce the monotonicity violation issue anymore. Thanks for the response! But yeah it seems like the onCluster issue still exist? |
Yes, could be, I haven't looked into it yet. |
I reproduced the monotonicity violation with streaming and chunked set to true, with a chunk size of 1MiB or less. Also, skimming through the code it seems that onCluster is not intended to fire when streaming is set to True:
As you can see above, |
This could be it, yeah. Thanks for finding this. If you want, you can open a PR with the fix. The monotonicity violation, however, still needs to be investigated. Can you provide some code that reproduces that bug? |
Hi, I have been trying to use this package for one of my task. Upon playing with the demo-streaming, I realized the onCluster for the stream target does not trigger with streaming set to true on the muxer. The chunked argument also causes issue with monotonicity violation. Is there any insight to how one might be able to realizes the creation of a cluster if streaming is set to false? without having to care for the position argument as the cluster would be pipe immediately to the server. Thanks!
The text was updated successfully, but these errors were encountered: