Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine IsCheckmate and IsStalemate functions to do all combinations in one pass #47

Open
Vadman97 opened this issue Apr 8, 2019 · 1 comment
Open

Combine IsCheckmate and IsStalemate functions to do all combinations in one pass #47

Vadman97 opened this issue Apr 8, 2019 · 1 comment
Labels
enhancement New feature or request low priority refactor wontfix This will not be worked on

Comments

@Vadman97
Copy link
Owner

Vadman97 commented Apr 8, 2019

don't need to recalculate - do all in one pass over the board.
@Vadman97 Vadman97 added the enhancement New feature or request label Apr 8, 2019
@Vadman97
Copy link
Owner Author

Vadman97 commented Apr 9, 2019

Brief testing shows that this will not benefit preformance - combining GetAllAttackableMoves to get both colors at once decreases performance because most of the time GetAllAttackableMoves is only called for one color. Closing for now

@Vadman97 Vadman97 closed this as completed Apr 9, 2019
@Vadman97 Vadman97 added low priority refactor wontfix This will not be worked on and removed performance labels Apr 9, 2019
@Vadman97 Vadman97 reopened this Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request low priority refactor wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Vadman97