Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InferenceFailedInfer, MlInference, or RunModel #779

Closed
3 tasks done
qryxip opened this issue Apr 7, 2024 · 0 comments · Fixed by #823
Closed
3 tasks done

InferenceFailedInfer, MlInference, or RunModel #779

qryxip opened this issue Apr 7, 2024 · 0 comments · Fixed by #823
Labels
OS:linux OS:mac OS:win 機能向上 要議論 実行する前に議論が必要そうなもの

Comments

@qryxip
Copy link
Member

qryxip commented Apr 7, 2024

内容

(追記) RunModelにすることになりました

ONNX Runtimeの推論失敗に対応するエラーは現在ErrorKind::InferenceFailed (Rust)、InferenceFaieldError (Python)、InferenceFailedException (Java)となっています。しかしRustのエラー命名の慣習 (かつ現在におけるvoicevox_coreの他のエラー)に従えば、ErrorKind::Infer/InferErrorのようになるはずです。

Pros 良くなる点

  • 命名の統一性を出せる

Cons 悪くなる点

実現方法

VOICEVOXのバージョン

N/A

OSの種類/ディストリ/バージョン

  • Windows
  • macOS
  • Linux

その他

MlInferenceError (名詞)とかでもいいかも?

@qryxip qryxip added 機能向上 要議論 実行する前に議論が必要そうなもの labels Apr 7, 2024
@qryxip qryxip changed the title InferenceFailedInfer InferenceFailedInfer or MlInference Aug 14, 2024
@qryxip qryxip changed the title InferenceFailedInfer or MlInference InferenceFailed → ~~Infer or MlInference~~ RunModel Sep 5, 2024
@qryxip qryxip changed the title InferenceFailed → ~~Infer or MlInference~~ RunModel InferenceFailed → ~~Infer or MlInference~~ RunModel Sep 5, 2024
@qryxip qryxip changed the title InferenceFailed → ~~Infer or MlInference~~ RunModel InferenceFailedInfer, MlInference, or RunModel Sep 5, 2024
@qryxip qryxip linked a pull request Sep 5, 2024 that will close this issue
@qryxip qryxip closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS:linux OS:mac OS:win 機能向上 要議論 実行する前に議論が必要そうなもの
Projects
None yet
1 participant