QA-15737 Get the market name from the device #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/util/devutil.js
Outdated
| @@ -191,4 +181,18 @@ devutil.makeIdentity = function(serial, properties) { | |||
| , ram: ram | |||
| } | |||
| } | |||
|
|
|||
| devutil.getDeviceMarketName = function(adb, serial) { | |||
| return adb.getDevice(serial).execOut('settings get global device_name', 'utf-8').then(function(deviceName) { | |||
There was a problem hiding this comment.
in some cases this field contains values like
irdkwmnsb
changed the title
Alk2017
force-pushed
the
a.chistov/get-market-name/QA-15737
branch
from
9d530c1 to
15af734
Compare
irdkwmnsb
reviewed
Jan 9, 2025
Alk2017
force-pushed
the
a.chistov/get-market-name/QA-15737
branch
from
716dbc0 to
58a64bb
Compare
irdkwmnsb
reviewed
Jan 13, 2025
| let product = properties['ro.product.name'] | ||
| let cpuPlatform = properties['ro.board.platform'] | ||
| let openGLESVersion = properties['ro.opengles.version'] | ||
| let marketName = await devutil.getDeviceMarketName() |
There was a problem hiding this comment.
An error might still raise here, since no .catch block in getDeviceMarketName. Maybe surround with try catch?
There was a problem hiding this comment.
add catch block with default value
irdkwmnsb
approved these changes
Jan 13, 2025
irdkwmnsb
approved these changes
Jan 14, 2025
Alk2017
force-pushed
the
a.chistov/get-market-name/QA-15737
branch
from
17b6a53 to
6675f4e
Compare
irdkwmnsb
approved these changes
Jan 14, 2025
-use DI syrup for devutil and refactoring depends on it -delete redundant part -add default value and warning -add different ways to get vendor's market name -get marketname from settings
Alk2017
force-pushed
the
a.chistov/get-market-name/QA-15737
branch
from
6675f4e to
9c79a18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-get marketname from settings