-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libpd script engine #7
Comments
We can implement multi-instance support once this merge request goes into libpd. |
instead of breaking multi-instance support in prototype, why not use a fork of libpd in the short term? you can make the change back to the canonical repo once the PR is merged. we had to do that for quickjs due to how it handles stack length checks (and are still using the fork). that seems to me to be a good solution in the short term, and could end up being a good (and stable) solution in the long term as well, depending on how it is handled. |
I agree that @JerrySievert's is the best idea you're willing to fork libpd on your own GitHub account, merge the PR, and use it as a submodule. |
I'm optimistic Miller is tackling this issue soon rendering this discussion obsolete. Multi-instance support is coming either way. |
Pull/Merge request here: #35 |
I've only tested this partially, but most things look great! |
|
https://github.com/libpd/libpd
Advantages:
Disadvantages:
ScriptEngine
subclass can simply fail with an error message if libpd is already in use.The text was updated successfully, but these errors were encountered: