-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Experimental Video Detection #38
Comments
ON HOLD! After doing further research I have come to the conclusion that there is no reliable one size fits all solution to determine session type. XDG_SESSION_TYPE is a none starter because it can be set by a display manger but what if you don't use one? It can also be set by the desktop or compositor but what if you use a desktop that does not set this envar? How about building a binary via SSH which sets XDG_SESSION_TYPE to tty? The build won't work on x11 or wayland as it assumes a kms setup. Other solutions rely on parsing loginctl such as |
I have reverted the main branch to the default RetroPie behaviour. I will keep the test_video branch as alternative for anyone wishing to use it. |
Replace the hacky and not very robust method of detecting x11/wayland/kms use via reading the envar XDG_SESSION_TYPE.
The following un-merged pull request has been submitted to the RetroPie Project. I would like to adopt it early with some modifications: RetroPie/RetroPie-Setup#3686
TARGETS:
The text was updated successfully, but these errors were encountered: