Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter /api/client/features by tag query parameter #601

Closed
Ampa1R opened this issue Dec 15, 2024 · 1 comment · Fixed by #608
Closed

Filter /api/client/features by tag query parameter #601

Ampa1R opened this issue Dec 15, 2024 · 1 comment · Fixed by #608
Labels
enhancement New feature or request

Comments

@Ampa1R
Copy link

Ampa1R commented Dec 15, 2024

Describe the feature request

I would like to request support for the tag query parameter in the /api/client/features endpoint for Unleash Edge

Background

Currently, the tag parameter is supported by Unleash but this functionality is not yet available in Unleash Edge

I saw a previous issue with fix for namePrefix #149 and it was mentioned:

Edge can't support filtering by tags, since that is not data we get from Unleash (it's not part of the client features contract), and Edge does not have access to the database

Despite mentioned issue adding support for the tag parameter would help bring consistency between the Unleash API and Edge API providing a seamless experience for users

Additionally i can't find mentions in the docs saying that the Edge API could work differently from the Unleash API. If there are other differences it would be really helpful to include these in the docs and create a list of unsupported features to assist users in understanding the limitations of the Edge

Solution suggestions

Possible solutions could be extending current API or create different endpoint that includes tags information

If these options couldn't be implemented in nearest future it would be great to note this details in docs

@Ampa1R Ampa1R added the enhancement New feature or request label Dec 15, 2024
@gastonfournier
Copy link
Contributor

Hi @Ampa1R, I think the best in this case is to add a note into documentation saying that this feature is not available in Edge. Filtering by tag is not even documented in our OpenAPI spec as we expect feature filtering should happen because of the API key you use that's bound to a project and environment.

Having filtering by tag inside unleash server adds additional complexity and probably should not be there in the first place. But changing that would be a breaking change. We'll continue discussing this internally but meanwhile I'll open a PR noting down this disparity between edge and unleash server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants