-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removal of Microsoft.CSharp package dependency #201
Comments
Hey @thompson-tomo, We'd like to do this but I'm not sure we can right now (easily at least). This is required for older versions of .NET to make We probably can and should rework the build in this project to bring it up to date but that's probably a bigger task than just this. So in the short term I'm open to suggestions that don't break this project for folks using older versions of .NET |
Hi @sighphyre before i logged this issue, i had taken a look and it for some reason was able to compile without that dependency however when i retested this morning, that wasn't the case. So must of been a cache issue or something. However what i have found is that if we add a netcoreapp 3.1 target this dependency is no longer needed. Hence see PR #204 for additional framework which externalize this dependency. :) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Pr is pending. Re-open |
* #201 Added netcoreapp 3.1 target to remove dependency on Microsoft.CSharp * Switch from netcoreapp 3.1 to net6 Co-authored-by: David Leek <[email protected]> --------- Co-authored-by: David Leek <[email protected]>
Describe the solution you'd like
I would like for the Microsoft.CSharp package to be removed as a dependency as it appears to not be used and as such is just bloating the dependencies
Describe alternatives you've considered
Implementing more target frameworks but if not needed for net standard 2.0 we don't gain by adding a framework rather than simply cleaning the package
Additional context
Appears to have been introduced with pull request #7 in 1.3.4
The text was updated successfully, but these errors were encountered: