Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of Microsoft.CSharp package dependency #201

Closed
thompson-tomo opened this issue Jan 21, 2024 · 4 comments · Fixed by #204
Closed

Removal of Microsoft.CSharp package dependency #201

thompson-tomo opened this issue Jan 21, 2024 · 4 comments · Fixed by #204

Comments

@thompson-tomo
Copy link
Contributor

Describe the solution you'd like
I would like for the Microsoft.CSharp package to be removed as a dependency as it appears to not be used and as such is just bloating the dependencies

Describe alternatives you've considered
Implementing more target frameworks but if not needed for net standard 2.0 we don't gain by adding a framework rather than simply cleaning the package

Additional context
Appears to have been introduced with pull request #7 in 1.3.4

@sighphyre
Copy link
Member

Hey @thompson-tomo,

We'd like to do this but I'm not sure we can right now (easily at least). This is required for older versions of .NET to make dynamic work. At the moment, we only seem to target .net standard, which would still need this I believe.

We probably can and should rework the build in this project to bring it up to date but that's probably a bigger task than just this. So in the short term I'm open to suggestions that don't break this project for folks using older versions of .NET

@sighphyre sighphyre moved this from New to Todo in Issues and PRs Jan 22, 2024
thompson-tomo added a commit to thompson-tomo/unleash-client-dotnet that referenced this issue Jan 22, 2024
@thompson-tomo
Copy link
Contributor Author

thompson-tomo commented Jan 22, 2024

Hi @sighphyre before i logged this issue, i had taken a look and it for some reason was able to compile without that dependency however when i retested this morning, that wasn't the case. So must of been a cache issue or something. However what i have found is that if we add a netcoreapp 3.1 target this dependency is no longer needed. Hence see PR #204 for additional framework which externalize this dependency. :)

Copy link

stale bot commented Feb 21, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 21, 2024
@thompson-tomo
Copy link
Contributor Author

Pr is pending. Re-open

@stale stale bot removed the stale label Feb 22, 2024
daveleek added a commit that referenced this issue Feb 22, 2024
* #201 Added netcoreapp 3.1 target to remove dependency on Microsoft.CSharp

* Switch from netcoreapp 3.1 to net6

Co-authored-by: David Leek <[email protected]>

---------

Co-authored-by: David Leek <[email protected]>
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues and PRs Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants