Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unleash edge chart doesn't allow specifying hostAliases #156

Closed
upcFrost opened this issue Jul 12, 2024 · 1 comment · Fixed by #157
Closed

Unleash edge chart doesn't allow specifying hostAliases #156

upcFrost opened this issue Jul 12, 2024 · 1 comment · Fixed by #157
Assignees
Labels
enhancement New feature or request

Comments

@upcFrost
Copy link

Describe the feature request

Hi, apparently the unleash-edge charge doesn't support setting hostAliases, which makes it a bit hard to use when the main unleash server is not on the public DNS. Could you please add a flag for it?

Background

No response

Solution suggestions

Smth simple like this in the deployment.yaml should do

      ...
      {{- with .Values.hostAliases }}
      hostAliases:
        {{- toYaml . | nindent 8 }}
      {{- end }}
@upcFrost upcFrost added the enhancement New feature or request label Jul 12, 2024
@chriswk chriswk self-assigned this Jul 15, 2024
@chriswk chriswk moved this from New to Todo in Issues and PRs Jul 15, 2024
@chriswk
Copy link
Member

chriswk commented Jul 15, 2024

Hi @upcFrost - thanks for this issue, I'll add a flag across all three charts

@chriswk chriswk linked a pull request Jul 15, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues and PRs Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants