Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entrypoint of PayloadEntry doesn't conform to the payload entry point defined in universal payload spec #3

Open
niruiyu opened this issue Oct 20, 2020 · 0 comments

Comments

@niruiyu
Copy link
Contributor

niruiyu commented Oct 20, 2020

Current entrypoint prototype is as below:
PayloadEntry (
IN UINTN BootloaderParameter,
IN UINTN FdBase
)

Spec defines the entry point prototype should be:
1st parameter: HobList
2nd parameter: ImageBase of payload entry

Currently the Payload entry locates the HOB from a pointer stored in stack:
(*(UINTN *)(UINTN)(PcdGet32(PcdPayloadStackTop) - 2 * sizeof(UINT64))).

It should directly assume the BootloaderParameter as the HOB base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant