OZ-L06: try-catch permit2Forwarder to avoid exposing DOS on multicall #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensha256
reviewed
Aug 28, 2024
src/base/Permit2Forwarder.sol
Outdated
| @@ -27,6 +27,6 @@ contract Permit2Forwarder { | |||
| external | |||
| payable | |||
| { | |||
| permit2.permit(owner, _permitBatch, signature); | |||
| try permit2.permit(owner, _permitBatch, signature) {} catch {} | |||
There was a problem hiding this comment.
maybe a quick comment that explains why its in a try catch?
| calls[2] = abi.encodeWithSelector(IPositionManager.modifyLiquidities.selector, mintCall, _deadline); | ||
|
|
||
| uint256 tokenId = lpm.nextTokenId(); | ||
| lpm.multicall(calls); |
There was a problem hiding this comment.
ideally this test would check
bytes[] memory results = lpm.multicall(calls);
assert(results[0] is correct revert reason)
assert(results[1] is correct revert reason)
i guess that revert reason is that the nonce is taken
There was a problem hiding this comment.
can you take a look now? im trying to do the Wrap__ error handling
cc @snreynolds
dianakocsis
requested changes
Aug 28, 2024
snreynolds
reviewed
Aug 31, 2024
the idea being we expose another generic |
hensha256
approved these changes
Sep 3, 2024
dianakocsis
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
OZ-L06: allow permit2Forwarder's
permit/permitBatchto fail via try-catch.Prevents DOS'ing multicalls containing
permit/permitBatchwhere an external party front runs the permit2Forwarder callDescription of changes
try-catch'd permit2Forwarder's
permit/permitBatch