Position Manager w/ UR-invokable delta resolving #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: update v4-core:latest (#105) * update core * rename lockAcquired to unlockCallback * update core; temporary path hack in remappings * update v4-core; remove remapping * wip: fix compatibility * update core; fix renaming of swap fee to lp fee * update core; fix events * update core; address liquidity salt and modify liquidity return values * fix incorrect delta accounting when modifying liquidity * fix todo, use CurrencySettleTake * remove deadcode * update core; use StateLibrary; update sqrtRatio to sqrtPrice * fix beforeSwap return signatures * forge fmt; remove commented out code * update core (wow gas savings) * update core * update core * update core; hook flags LSB * update core * update core * chore: update v4 core (#115) * Update v4-core * CurrencySettleTake -> CurrencySettler * Snapshots * compiling but very broken * replace PoolStateLibrary * update currency settle take * compiling * wip * use v4-core's forge-std * test liquidity increase * additional fixes for collection and liquidity decrease * test migration * replace old implementation with new --------- Signed-off-by: saucepoint <[email protected]> Co-authored-by: 0x57 <[email protected]>
* wip: consolidation * further consolidation * consolidate to single file * yay no more stack too deep * some code comments
Co-authored-by: 0x57 <[email protected]>
saucepoint
commented
Jun 20, 2024
Comment on lines
111
to
118
| // Update the tokensOwed0 and tokensOwed1 values for the caller. | ||
| // if callerDelta < 0, existing fees were re-invested AND net new tokens are required for the liquidity increase | ||
| // if callerDelta == 0, existing fees were reinvested (autocompounded) | ||
| // if callerDelta > 0, some but not all existing fees were used to increase liquidity. Any remainder is added to the position's owed tokens | ||
| if (callerDelta.amount0() > 0) { | ||
| position.tokensOwed0 += uint128(callerDelta.amount0()); | ||
| range.key.currency0.take(manager, address(this), uint128(callerDelta.amount0()), true); | ||
| callerDelta = toBalanceDelta(0, callerDelta.amount1()); |
There was a problem hiding this comment.
possibly contentious...
for cases where some - but not all - fees are used to increase liquidity, any remainder fees are credited to the position's tokensOwed. it feels natural in the vanilla case, but in the batching world i wonder if the credit could be used towards another operation..
* change add liq accounting * remove rand comments * fix exact fees * use closeAllDeltas * comments cleanup * additional liquidity tests (#129) * additional increase liquidity tests * edge case of using cached fees for autocompound * wip * fix autocompound bug, use custodied and unclaimed fees in the autocompound * fix tests and use BalanceDeltas (#130) * fix some assertions * use BalanceDeltas for arithmetic * cleanest code in the game??? * additional cleaning * typo lol * autocompound gas benchmarks * autocompound excess credit gas benchmark * save 600 gas, cleaner code when moving caller delta to tokensOwed --------- Co-authored-by: saucepoint <[email protected]>
* update decrease * update collect * update decrease/collect * remove delta function * update burn
|
Closing in favor of #141 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wippity wip
Outstanding items
exclusive zeroOut lock -- prevent hooks from zeroing-out