From 9edb230502b4d0a3bbfdce34767e6049b06011e3 Mon Sep 17 00:00:00 2001 From: Sara Reynolds Date: Thu, 20 Jun 2024 14:47:05 -0400 Subject: [PATCH] remove rand comments --- contracts/interfaces/INonfungiblePositionManager.sol | 7 ++----- contracts/types/LiquidityRange.sol | 7 +------ 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/contracts/interfaces/INonfungiblePositionManager.sol b/contracts/interfaces/INonfungiblePositionManager.sol index ee8b0c66..6b09efe5 100644 --- a/contracts/interfaces/INonfungiblePositionManager.sol +++ b/contracts/interfaces/INonfungiblePositionManager.sol @@ -6,13 +6,10 @@ import {LiquidityRange} from "../types/LiquidityRange.sol"; interface INonfungiblePositionManager { struct TokenPosition { - address owner; // 160 - LiquidityRange range; // 576 + address owner; + LiquidityRange range; } - // using 736 - 3 SLOTS - // total 768 - 32 bits free space - // NOTE: more gas efficient as LiquidityAmounts is used offchain function mint( LiquidityRange calldata position, diff --git a/contracts/types/LiquidityRange.sol b/contracts/types/LiquidityRange.sol index 363575d2..4f664027 100644 --- a/contracts/types/LiquidityRange.sol +++ b/contracts/types/LiquidityRange.sol @@ -4,16 +4,11 @@ pragma solidity ^0.8.24; import {PoolKey} from "@uniswap/v4-core/src/types/PoolKey.sol"; struct LiquidityRange { - PoolKey poolKey; // 528 + PoolKey poolKey; int24 tickLower; int24 tickUpper; } -// can we force integrators to instead pass in the liquidity range? and we only store a hash? - -// 2 256 = 512 -// 576 - type LiquidityRangeId is bytes32; /// @notice Library for computing the ID of a liquidity range