From 8055ecb9cf377003930001b82a5f389d797b9172 Mon Sep 17 00:00:00 2001 From: Mark Toda Date: Tue, 5 Nov 2024 21:41:20 -0800 Subject: [PATCH] fix: remove unused v4Owner variable --- src/UniswapV4DeployerCompetition.sol | 4 ---- test/UniswapV4DeployerCompetition.t.sol | 6 ++---- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/UniswapV4DeployerCompetition.sol b/src/UniswapV4DeployerCompetition.sol index 66e4164b..ffd260be 100644 --- a/src/UniswapV4DeployerCompetition.sol +++ b/src/UniswapV4DeployerCompetition.sol @@ -17,8 +17,6 @@ contract UniswapV4DeployerCompetition is IUniswapV4DeployerCompetition { /// @dev The submitter of the best address found so far address public bestAddressSubmitter; - /// @dev The owner of the v4 contract - address public immutable v4Owner; /// @dev The deadline for the competition uint256 public immutable competitionDeadline; /// @dev The init code hash of the V4 contract @@ -32,13 +30,11 @@ contract UniswapV4DeployerCompetition is IUniswapV4DeployerCompetition { constructor( bytes32 _initCodeHash, - address _v4Owner, uint256 _competitionDeadline, address _exclusiveDeployer, uint256 _exclusiveDeployLength ) { initCodeHash = _initCodeHash; - v4Owner = _v4Owner; competitionDeadline = _competitionDeadline; exclusiveDeployDeadline = _competitionDeadline + _exclusiveDeployLength; deployer = _exclusiveDeployer; diff --git a/test/UniswapV4DeployerCompetition.t.sol b/test/UniswapV4DeployerCompetition.t.sol index fe988840..b119a93f 100644 --- a/test/UniswapV4DeployerCompetition.t.sol +++ b/test/UniswapV4DeployerCompetition.t.sol @@ -30,10 +30,8 @@ contract UniswapV4DeployerCompetitionTest is Test { deployer = makeAddr("Deployer"); vm.prank(deployer); initCodeHash = keccak256(abi.encodePacked(type(PoolManager).creationCode, uint256(uint160(v4Owner)))); - competition = new UniswapV4DeployerCompetition( - initCodeHash, v4Owner, competitionDeadline, deployer, exclusiveDeployLength - ); - assertEq(competition.v4Owner(), v4Owner); + competition = + new UniswapV4DeployerCompetition(initCodeHash, competitionDeadline, deployer, exclusiveDeployLength); } function test_updateBestAddress_succeeds(bytes32 salt) public {