Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate out approveERC20 from Payments.sol into separate file #319

Open
zhongeric opened this issue Sep 19, 2023 · 1 comment
Open

Separate out approveERC20 from Payments.sol into separate file #319

zhongeric opened this issue Sep 19, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@zhongeric
Copy link
Contributor

ApproveERC20 is only used to set max approvals on OpenSea's conduit + Sudoswap for NFT trades, and doesn't really fit well into the Payments module in Universal Router.
@zhongeric zhongeric added the good first issue Good for newcomers label Sep 27, 2023
@tutizaraz
Copy link

@zhongeric hey, is this issue still relevant? It looks pretty outdated. Decided to ask before potentially working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tutizaraz @zhongeric