From 29a8e465781d23fe92357b4fcf0be80f41cfee09 Mon Sep 17 00:00:00 2001 From: Morten Brekkevold Date: Tue, 15 Oct 2024 05:20:09 +0000 Subject: [PATCH 1/2] Run JS tests under Node 18 Ensures we use the same Node version as our docker test image. --- .github/workflows/build-and-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 5596ca4a42..013def231e 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -136,7 +136,7 @@ jobs: - run: chrome --version - uses: actions/setup-node@v4 with: - node-version: 16 + node-version: 18 - name: npm install run: | From 2ef65c3c02342b3b91f576eac894c7dba89c60f0 Mon Sep 17 00:00:00 2001 From: Morten Brekkevold Date: Tue, 15 Oct 2024 06:38:04 +0000 Subject: [PATCH 2/2] Disable OpenSSL during JS tests PhantomJS is outdated and tries to use parts of OpenSSL that are no longer there. We shouldn't need SSL for the JS tests, so this attempts to disable it temporarily during the test run. --- .github/workflows/build-and-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 013def231e..3216c54a0c 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -144,7 +144,7 @@ jobs: npm ci - name: npm test - run: xvfb-run -a npm test + run: OPENSSL_CONF=/dev/null xvfb-run -a npm test working-directory: ./python/nav/web/static/js - name: Upload JavaScript test reports