From 7529721a1d0cd02bdff7310d4b514bc0ecf9cd54 Mon Sep 17 00:00:00 2001 From: Johanna England Date: Tue, 5 Sep 2023 10:30:40 +0200 Subject: [PATCH] Have test for empty address and invalid address --- tests/integration/models/alert_test.py | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/tests/integration/models/alert_test.py b/tests/integration/models/alert_test.py index 63c085d2da..a824245ddb 100644 --- a/tests/integration/models/alert_test.py +++ b/tests/integration/models/alert_test.py @@ -16,21 +16,30 @@ import pytest -def test_delete_alert_subscription(db, alert, alertsub, account_alert_queue): +def test_delete_alert_subscription(alert, alertsub, account_alert_queue): alertsub.delete() assert not AccountAlertQueue.objects.filter(pk=account_alert_queue.pk).exists() assert not AlertQueue.objects.filter(pk=alert.pk).exists() +def test_sending_alert_to_alert_address_with_empty_address_will_raise_error( + alert_address, alert, alertsub +): + with pytest.raises(InvalidAlertAddressError): + alert_address.send(alert, alertsub) + + def test_sending_alert_to_alert_address_with_invalid_address_will_raise_error( - db, alert_address, alert, alertsub + alert_address, alert, alertsub ): + alert_address.address = "abc" + alert_address.save() with pytest.raises(InvalidAlertAddressError): alert_address.send(alert, alertsub) def test_sending_alert_to_alert_address_with_invalid_address_will_delete_alert_and_fail( - db, alert, account_alert_queue + alert, account_alert_queue ): assert not account_alert_queue.send() assert not AlertQueue.objects.filter(pk=alert.pk).exists()