-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
classic only build not dealing with filters/quantization well #3020
Comments
I will submit a fix shortly... |
Whether or not there should be quantization is debatable. It's perfectly well defined and supportable by classic format, it's just that there is not any known use. I think we discussed whether classic should support quantization before, and I remember concurring that it is OK to turn it off for classic. My views have evolved since then. As long as it's working for classic, no reason to turn it off in my mind. YMMV. In any case, NCO supports quantization for classic via it's internal algorithms. |
It does not work for classic. Putting it in for classic would require diving into the libsrc code, which is not something I would choose to do without great need. Of course it makes sense for classic, and would even provide benefit: a quantized classic file would gzip to a much smaller size. My only concern here is that currently netcdf-fortran fails for classic-only netcdf-c library because quantize constants are missing. Obviously we want a classic only build to work. So my thought was to detect classic only builds, and then to set quantization to "no" (since there is no quantize for classic only). Then netcdf-fortran could see that setting and know not to include the quantize constants. |
OK, nevermind me, I misinterpreted your original message. Sounds like we're in agreement on the hypothetical value of having quantization in classic files. |
For a classic only build there should be no filters or quantization.
The text was updated successfully, but these errors were encountered: