Two issues with my draft PR

[winash12]

In my draft PR all of the 4 methods require using either divergence or vorticity as an argument. Is it of any use to add the units of vorticity or divergence to https://github.com/Unidata/MetPy/blob/main/src/metpy/units.py ?

Secondly the changes that I made to kinematics.py seem to have disappeared on the main branch of MetPy. May I know where my changes went ?

[dcamron]

Vorticity has units of $time ^{-1}$. This is a valid unit already existing in pint, and if you use MetPy's vorticity calculation you will get back eg $0.00015 s^{-1}$ as 0.0015 * units('1/s'). Divergence, as a similar derivative $\frac{\partial u}{\partial x}...$ will result in units of $u.units / length$. For our wind vector, this results in $distance / time / distance$ or $time^{-1}$. So as long as $u$ has valid units in Pint, the output of divergence will as well. Let me know if I'm missing anything, but these shouldn't require any new unit definitions.

I'm not sure what changes you might be missing on your PR. We haven't made any changes to your code, and your changes won't go in to the main branch of MetPy until your PR is reviewed, accepted, and merged.

Let's continue that discussion and any further questions or clarifications you have as comments on your PR itself moving forward, available under "Add a comment" at the bottom of #3266.