Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent connection lost #141

Open
UncleGoogle opened this issue Sep 8, 2020 · 0 comments
Open

Silent connection lost #141

UncleGoogle opened this issue Sep 8, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@UncleGoogle
Copy link
Owner

Describe the bug
Connection lost but plugin does not communicate this to Galaxy.

Expected behavior
Either do not lost connection (reassign _simpleauth cookie when SetCookie in header ??)
or just raised Connection Lost properly.

Currently there is 302 to login page, not 403 or similar as was assumed in the code.

Possible solution

Maybe we should base on hbflush SetCookie header that stores have error reason (need to use redirect=False) or just assume when there is 302 (but the first seems more valid)

Provide logs

aiohttp.client_exceptions.ContentTypeError: 0, message='Attempt to decode JSON with unexpected mimetype: text/html; charset=utf-8', url=URL('https://www.humblebundle.com/login?goto=/api/v1/user/order&qs=')
2020-09-07 20:48:20,649 - root - DEBUG - Sending data: {"jsonrpc": "2.0", "id": "32975", "error": {"code": 0, "message": "Unknown error", "data": "0, message='Attempt to decode JSON with unexpected mimetype: text/html; charset=utf-8', 

-> from get_owned_games

@UncleGoogle UncleGoogle added the bug Something isn't working label Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant