Skip to content

Commit

Permalink
fix for high hole_brim_distance
Browse files Browse the repository at this point in the history
When multiple parts were laid inside each other like russion dolls,
then some bad XOR voodoo would happen and some regions in between two parts would get fully filled with brim
rather than no brim being generated anywhere on the inside of parts.
  • Loading branch information
BagelOrb committed Mar 17, 2022
1 parent 11ed0c7 commit 665ea66
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/SkirtBrim.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -236,10 +236,9 @@ Polygons SkirtBrim::getInternalHoleExclusionArea(const Polygons& outline, const
Polygon hole_poly = part[hole_idx];
hole_poly.reverse();
Polygons disallowed_region = hole_poly.offset(10u).difference(hole_poly.offset( - line_widths[extruder_nr] / 2 - hole_brim_distance));
ret.add(disallowed_region);
ret = ret.unionPolygons(disallowed_region);
}
}
ret.unionPolygons();
return ret;
}

Expand Down

0 comments on commit 665ea66

Please sign in to comment.