Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] missing documentation on FastCounterInterface constraints #159

Open
qku opened this issue Sep 30, 2024 · 1 comment
Open

[Bug] missing documentation on FastCounterInterface constraints #159

qku opened this issue Sep 30, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@qku
Copy link
Contributor

qku commented Sep 30, 2024

Version

current main

What is affected by the bug?

The constraints for fast counter hardware are a dictionary. The keys are nowhere specified however. Therefore I am having difficulty in writing a hardware module implementing the FastCounterInterface.

When does the bug occur?

not applicable

How do we replicate the issue?

not applicable

Expected behavior

The structure of the dictionary returned by get_constraints() is documented in the interface, e.g. in the docstring of this method.

Relevant log output

No response

Additional Comments

Looking through existing hardware implementations, I could find the following keys in FastComtec:

constraints['hardware_binwidth_list'] = list(self.minimal_binwidth * (2 ** np.array(np.linspace(0,24,25))))
constraints['max_sweep_len'] = 6.8
constraints['max_bins'] = 6.8 / 0.2e-9

If this implementation is correct, the docstring for get_constraints() is actually incorrect, since it states:

The items of the keys are again dictionaries which have the generic
dictionary form:
{'min': ,
'max': ,
'step': ,
'unit': ''}

Only the key 'hardware_binwidth_list' differs, since they
contain the list of possible binwidths.

Contact Details

No response

@timoML
Copy link
Contributor

timoML commented Oct 7, 2024

I started overhauling the FastCounterInterface in this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants