Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Sequence generator analog levels not updated #102

Open
timoML opened this issue Sep 27, 2023 · 1 comment
Open

[Bug] Sequence generator analog levels not updated #102

timoML opened this issue Sep 27, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@timoML
Copy link
Contributor

timoML commented Sep 27, 2023

Version

current main

What is affected by the bug?

The sequence generator holds a copy of __analog_levels to calculate the swing of any analog output. The __analog_levels get set by sequencegenerator.set_pulse_generator_settings(). However, if a script or external manufacturer software is changing the levels (without a call to this method), samples might no be created with the correct amplitude.
Probably it's enough to call _read_settings_from_device() before creating waves.

When does the bug occur?

Changing a pulser's physical amplitude settings by external script.

How do we replicate the issue?

Eg. with Keysight AWGs:

  1. Sample a waveform
  2. Change the ampliute settings in the front panel
  3. Sample waveform again

Expected behavior

The waveforms should have the physical amplitude set in the "predefined methods" tab.

Relevant log output

No response

Additional Comments

No response

Contact Details

[email protected]

@timoML timoML added the bug Something isn't working label Sep 27, 2023
@Neverhorst
Copy link
Member

Hi @timoML ,

the extra settings buffer in the hardware module was introduced by me specifically for the Tektronix AWG70k series. The reasoning was that this setting is needed quite frequently in the pulsed toolchain and a hardware query of the pulse generator settings (sample rate, voltages, marker levels, etc.) is quite slow on these devices.
Since you can change all these settings from qudi, I thought this would be the lesser evil because you do not need to use the vendor software directly.
But if it proves to be a problem for users, it needs to be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants