Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting more algorithms? #1

Open
friday opened this issue Sep 24, 2018 · 1 comment
Open

Supporting more algorithms? #1

friday opened this issue Sep 24, 2018 · 1 comment

Comments

@friday
Copy link
Member

friday commented Sep 24, 2018

More algorithms can be supported by switching hashlib.algorithms for hashlib.algorithms_available. I tried this originally, but opted out.

  1. I got too many algorithms (['sha3-512', 'shake128', 'sha3-384', 'sha3-256', 'sha512-224', 'blake2s256', 'shake256', 'blake2b512', 'md4', 'md5', 'sha1', 'sha224', 'sm3', 'sha512-256', 'mdc2', 'sha3-224', 'sha384', 'md5-sha1', 'sha256', 'sha512', 'ripemd160', 'whirlpool']). Ulauncher didn't handle this (no max-height or scrollbar) so the whole result list couldn't fit on my screen (1080p). Late addition: ExtensionSmallResultItem could be used to fit more items on the screen
  2. I'm confused about the dependency and platform-aspect. According to the documentation the extra algorithms require OpenSSL. Some people switched to alternatives like LibreSSL since the heartbleed exploit. Even with OpenSSL the feature support depends on how it was compiled. Overall this makes me uneasy about the support here. Ulauncher keywords are added in the static manifest, so they can't be handled conditionally unfortunately.

I would add the extra algorithms if there were no caveats or if there were ways around them, but this isn't currently the case.

Less than 24 hours after I published the extension it was forked though, so now people can choose 👍 Fast work @xtrcode 😆

@BobbyWibowo
Copy link

It seems @xtrcode's fork is no longer maintained, unfortunately :(
It also doesn't conform with Extension API v2 (e.g. the lack of versions.json file, causing installation to fail)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants