Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

好像有一些 tests fail 掉了 #10

Open
unionx opened this issue Apr 21, 2015 · 3 comments
Open

好像有一些 tests fail 掉了 #10

unionx opened this issue Apr 21, 2015 · 3 comments

Comments

@unionx
Copy link

unionx commented Apr 21, 2015

我看看能不能尝试 fix

@unionx
Copy link
Author

unionx commented Apr 21, 2015

好像一些 v2 的 api 没有写,我正在改代码,估计要改很多了......

@UglyTroLL
Copy link
Owner

Cool! Thanks!
v2的API确实当时都没有支持

@corningsun
Copy link
Contributor

corningsun commented Jan 14, 2017

修改是增加V2方法还是,直接替换掉V1的方法?
现在代码里面是这样处理的:

  public DoubanSubjectObj getMovieInfoById (long movieId) throws DoubanException, IOException {
    String url = RequestUrls.DOUBAN_MOVIE_SUBJECT_PREFIX + "/" + movieId;
    DoubanSubjectObj movie = this.client.getResponse(url, null, DoubanSubjectObj.class, false);
    return movie;
  }

  public com.dongxuexidu.douban4j.model.v2.DoubanSubjectObj getV2MovieInfoById(long movieId) throws DoubanException, IOException {
    String url = RequestUrls.DOUBAN_MOVIE_V2_SUBJECT_PREFIX + "/" + movieId;
    com.dongxuexidu.douban4j.model.v2.DoubanSubjectObj movie = this.client.getResponseInJson(url, null, com.dongxuexidu.douban4j.model.v2.DoubanSubjectObj.class, false);
    return movie;
  }

另外,单元测试中的V1方法还需要保留吗?

大家可以交流下升级到V2的事情,分下任务,不要做重复劳动了。。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants