Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Appropriate content from the content doc to website at appropriate places #226

Open
strongSoda opened this issue May 12, 2018 · 18 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@strongSoda
Copy link
Collaborator

strongSoda commented May 12, 2018

All the content is available in the doc hosted in repo. Your task is to add that content in appropriate divs under appropriate headings in the website homepage.

The current site is here https://jeevanrakht.herokuapp.com/index.html

The content is in _workabkes/content folder here https://github.com/UdacityFrontEndScholarship/jeevan-rakht/blob/master/_workables/content/JeevanRakht%20-%20Content%20Doc%20(final).pdf

@Karthik781
Copy link

@strongSoda i will work on it.

@strongSoda
Copy link
Collaborator Author

@Karthik781

Can you pls elaborate how much and by when will u complete this task to give us a clear idea?

@Karthik781
Copy link

@strongSoda By end of tomorrow. aren't pages are connected to homepage yet?

@gauravsinghaec
Copy link
Collaborator

@Karthik781 please let us know if you are still working on it?

@gauravsinghaec gauravsinghaec added the help wanted Extra attention is needed label May 17, 2018
@Karthik781
Copy link

Got busy with back to back exams. Will complete by end of tomorrow.

@gauravsinghaec
Copy link
Collaborator

@Karthik781 any update? are you facing any roadblocks?

@Karthik781
Copy link

@gauravsinghaec Sorry man, last week was hectic with internship interviews etc.. can you give me this weak?

@gauravsinghaec
Copy link
Collaborator

hey @Karthik781 that's totally ok. Yeah, I can understand but it will help the team if you can give us the clear idea. Sometimes honest feedback helps so let me ask specifically,

  1. Did you start the work?
    If yes then what percentage of tasks are done until today?
  2. Will you be comfortable or want us to pass it to other if you are not getting enough time.?

@Karthik781
Copy link

@gauravsinghaec Didn't started yet! will complete by weekend if thats okay.

@Ruchika30
Copy link

@gauravsinghaec Can I work on it?

@gauravsinghaec
Copy link
Collaborator

@Ruchika30 yeah sure, before that we would like to know if you can come up with some work before the weekend.

@Ruchika30
Copy link

@gauravsinghaec I went though the content of the doc & the site too. Please tell me am I suppose to insert the complete information provided in the doc on the page ? The content is highly informative.

@gauravsinghaec
Copy link
Collaborator

@Ruchika30 that's so nice of you. Please work on the homepage related content first and share your work here. Then you can work on other content. is that ok?

@Ruchika30
Copy link

@gauravsinghaec Sorry to say , but it looked a mess after the whole detailed content being inserted when I just tried inserting for "Why donate". I am following the doc given in the above link. https://github.com/UdacityFrontEndScholarship/jeevan-rakht/blob/master/_workables/content
Pls suggest.

@gauravsinghaec
Copy link
Collaborator

gauravsinghaec commented May 25, 2018

@Ruchika30 as mentioned
The content is in _workabkes/content folder here https://github.com/UdacityFrontEndScholarship/jeevan-rakht/blob/master/_workables/content/JeevanRakht%20-%20Content%20Doc%20(final).pdf

The current site is here https://jeevanrakht.herokuapp.com/index.html
You can see the myth section is blank on homepage (Open the site from above link)

You can reach out to us on slack. DM me/Imran/Vidit or ping in the channel #cp_jvn_rkht on slack

codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue May 31, 2018
This commit is done for adding appropriate content from the content docs to websites at appropriate places.
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue May 31, 2018
This is commit is done for eligibility content taking from content docs to add at eligibility html link on website.
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue May 31, 2018
This commit is done to add how_to_donate content taking from content docs added at how_to_donate html link on website.
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue May 31, 2018
This commit is done to add content of FAQ taking from contents doc at FAQ html link on website.
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue May 31, 2018
This commit is done to add content of info taken from the content docs at info html link at website.
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue May 31, 2018
This commit is done to giving the style to various contents on website using style.css .
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue May 31, 2018
This commit is done to add html link content of contact to website,
Hey! I have no contact detail so please add it after further committing.
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue May 31, 2018
This is commit is done for eligibility content taking from content docs to add at eligibility html link on website.
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue May 31, 2018
This commit is done to add content of FAQ taking from contents doc at FAQ html link on website.
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue May 31, 2018
This commit is done to add how_to_donate content taking from content docs added at how_to_donate html link on website.
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue May 31, 2018
This commit is done to add content of info taken from the content docs at info html link at website.
@gauravsinghaec
Copy link
Collaborator

@samyak8853 Great show buddy. Can you please deploy it on Heroku or share any URL to see the changes live?
Few things to note:

  1. The & in navigation (Faq & info) is not corrected by HTML utility &
  2. I would check if we need to have two separate page for Faq and Info or it will be a single page.
  3. We have main.css for website, is there any specific reason for creating another css file styles.css

@codestryker
Copy link

Today i will clear the issues for my pull request.

codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue Jun 1, 2018
I add the code for styling the text insides the labels given at the websites which needs appropriate contents at appropriate place.
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue Jun 1, 2018
I commit this code to give the content to the about label on the website using html link.
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue Jun 1, 2018
I commit this code to give the content to the contact label on the website using html link.
Note: It need further committing because i have no contact details
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue Jun 1, 2018
I commit this code to give the content to the  eligibility label on the website using html link.
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue Jun 1, 2018
I commit this code to give the content to the FAQ&Info label on the website using html link.
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue Jun 1, 2018
I commit this code to give the content to the how to donate label on the website using html link.
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue Jun 1, 2018
I commit this code to give the contents to the all  labels on the website using html link.
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue Jun 1, 2018
I commit this code to give the content to the why to donate label on the website using html link.
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue Jun 8, 2018
here i style the content of labels and style the favicon.png for it's web pages
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue Jun 8, 2018
add the text with favicon.png to the about label web page
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue Jun 8, 2018
I added favicon.png icon to the web page of label but need further commiting for it's extra details
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue Jun 8, 2018
i added more content to it's label and favicon.png icon to it's web page.
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue Jun 8, 2018
i added content to FAQ and information  labels and also add favicon.png icon on it
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue Jun 8, 2018
i added text to the (how to donate) label's web page also added favicon.png icon on it web page
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue Jun 8, 2018
i give the HTML url of all labels in it
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue Jun 8, 2018
i added content to (why to donate) label and added favicon.png icon on it web page.
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue Jun 15, 2018
add the text with favicon.png to the about label web page
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue Jun 15, 2018
I added favicon.png icon to the web page of label but need further committing for it's extra details
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue Jun 15, 2018
i added more content to it's label and favicon.png icon to it's web page.
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue Jun 15, 2018
i added content to FAQ and information  labels and also add favicon.png icon on it
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue Jun 15, 2018
i added text to the (how to donate) label's web page also added favicon.png icon on it web page
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue Jun 15, 2018
i added content to (why to donate) label and added favicon.png icon on it web page.
codestryker pushed a commit to codestryker/jeevan-rakht that referenced this issue Jun 16, 2018
here i style the content of labels and style the favicon.png for it's web pages
@gauravsinghaec
Copy link
Collaborator

All good so far @samyak8853. Can you please reduce your commits before I merge your PR. Now you can see there are 40 commits. Also please give some meaningful comments to your commit messages. Please follow the below link for the good git commit messages.
https://udacity.github.io/git-styleguide/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants