Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolutionScale is not set in some cases #1

Open
python273 opened this issue Mar 11, 2021 · 1 comment
Open

resolutionScale is not set in some cases #1

python273 opened this issue Mar 11, 2021 · 1 comment

Comments

@python273
Copy link

On https://dev.macrostrat.org/mars/syrtis-jezero/layers
if you change "terrain exaggeration", it doesn't set correct resolutionScale

Seems to be related to this code, it only sets it once, since resolutionScale is not changed, but there's a new element:

useEffect(() => {
const { cesiumElement } = ref.current ?? {};
if (cesiumElement == null) return;
ref.current.cesiumElement.resolutionScale = resolutionScale;
// Enable anti-aliasing
ref.current.cesiumElement.scene.postProcessStages.fxaa.enabled = true;
}, [resolutionScale]);

Not related, but seems like "Quality" selector is also broken

@davenquinn
Copy link
Member

Thanks for the report and collaboration!

I had actually been confused by the genesis of this bug but I think your diagnosis is correct. I'll try to work in a fix soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants