Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snow17.py (commit #55) generates non-zero outflow in absence of precip and snowmelt #69

Open
rtroper0 opened this issue Apr 19, 2018 · 1 comment

Comments

@rtroper0
Copy link

snow17.py generate a non-zero outflow even when there is no precip or snowmelt. In the screenshot below, cumulative outflow (after all snow has melted) exceeds cumulative precip:

image

I noticed that when I comment out the w_q term in line 234 (see screenshot below), I no longer see the discrepancy between cumulative outflow and cumulative precip.

image

Here's a plot of the results after commenting out w_q in line 234:

image

Commenting out w_q in line 234 appears to have resolved the issue in this particular case, but I don't know if it's a sound solution. Somewhere in the code, it seems there must be an implementation error, because the unedited snow17.py code generates a non-zero outflow in the absence of precip and snowmelt.

@ShihengDuan
Copy link

Is there any update? Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants