Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for global param files #36

Open
tbohn opened this issue Feb 3, 2016 · 3 comments
Open

Add support for global param files #36

tbohn opened this issue Feb 3, 2016 · 3 comments
Labels

Comments

@tbohn
Copy link
Contributor

tbohn commented Feb 3, 2016

Tonic could/should convert global parameter files between different versions.

In addition, the global parameter file could/should serve as the configuration file for tonic to set options. After all, that's the purpose of the global parameter file in VIC.

So, this kills 2 birds with one stone!

@tbohn
Copy link
Contributor Author

tbohn commented Feb 3, 2016

Note: I was going to suggest that the global param file could be used as the config file for the forcing file conversion as well, but I see that there already exists some sort of config file for that. Perhaps it's just as well, particularly if the options in the forcing config file differ from what's in the global param file.

Anyway, any thoughts on how to handle this would be appreciated.

@jhamman
Copy link
Member

jhamman commented Feb 4, 2016

I have some scratch code somewhere around here that parses a VIC global parameter file. It's pretty easy actually. I'd be happy to pull a first draft of the parser together.

@jhamman jhamman added the vic.5 label Feb 4, 2016
@jhamman
Copy link
Member

jhamman commented Feb 5, 2016

Here's a gist I have that parses the global config file. https://gist.github.com/jhamman/8bee9f287ccde4200666#file-vic_global_options-py

I think it has most of what we would want in there. We need to handle output variables still, and probably add a compliance checker of some kind.

When I get a chance to test it out a bit more, I'll drop it into tonic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants